Conversation
dgageot
commented
Feb 21, 2019
dgageot
commented
- Improve the static pages
- Improve the Go structs to make them more friendly to the documentation generator (test section and profile patches)
- fixed comments here and there
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
dgageot
force-pushed
the
improve-docs-v3
branch
from
e42b359 to
d4dc9bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #1682 +/- ##
==========================================
+ Coverage 47.48% 47.56% +0.07%
==========================================
Files 122 122
Lines 5456 5464 +8
==========================================
+ Hits 2591 2599 +8
Misses 2604 2604
Partials 261 261
Continue to review full report at Codecov.
|
dgageot
added
the
docs-modifications
|
Please visit http://35.236.109.79:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
| [Docker Engine APIs](https://docs.docker.com/develop/sdk/). You can, however, | ||
| ask Skaffold to use the [command-line interface](https://docs.docker.com/engine/reference/commandline/cli/) | ||
| [Docker Engine APIs](https://docs.docker.com/develop/sdk/). Skaffold can, however, | ||
| be aked to use the [command-line interface](https://docs.docker.com/engine/reference/commandline/cli/) |
There was a problem hiding this comment.
| be aked to use the [command-line interface](https://docs.docker.com/engine/reference/commandline/cli/) | |
| be asked to use the [command-line interface](https://docs.docker.com/engine/reference/commandline/cli/) |
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
| To use the local Docker daemon, add build type `local` to the `build` section | ||
| of `skaffold.yaml`. The following options can optionally be configured: | ||
|
|
||
| {{< schema root="LocalBuild" >}} |
There was a problem hiding this comment.
looking at this rendered it is a bit weird that the default is empty for push - shouldn't it be false there too?
There was a problem hiding this comment.
In fact it depends on the k8s context.
There was a problem hiding this comment.
oh yeah, this is due to a previous merge - I guess it's a more complex logic as currently on skaffold.dev it is manually specified as "false for local clusters, true for remote clusters."...
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
LGTM, caveat: 1 typo and 1 question for complex default values
dgageot
force-pushed
the
improve-docs-v3
branch
from
d4dc9bc to
16d6c4f
Compare
|
Let me fix the typo |
|
Travis is green but can't seem to get the status updated. Let's merge this PR |
5 participants
