Bail out on docker build error#1723
Merged
dgageot merged 2 commits intoGoogleContainerTools:masterfrom Mar 5, 2019
Merged
Conversation
michaelfig
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1723 +/- ##
==========================================
- Coverage 46.91% 46.89% -0.02%
==========================================
Files 126 126
Lines 6167 6169 +2
==========================================
Hits 2893 2893
- Misses 2976 2977 +1
- Partials 298 299 +1
Continue to review full report at Codecov.
|
priyawadhwa
reviewed
Mar 4, 2019
Contributor
priyawadhwa
left a comment
priyawadhwa
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Just left one comment.
Contributor
|
I'll merge this and add an integration test |
dgageot
approved these changes
Mar 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1712