Skip to content

Test that images that can’t be built are not pushed#1729

Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:add-local-builder-tests
Mar 5, 2019
Merged

Test that images that can’t be built are not pushed#1729
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:add-local-builder-tests

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Mar 5, 2019

Also fix inspect related tests

Signed-off-by: David Gageot david@gageot.net

Also fix inspect related tests

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 5, 2019

Codecov Report

Merging #1729 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1729      +/-   ##
==========================================
+ Coverage   46.92%   47.05%   +0.12%     
==========================================
  Files         126      126              
  Lines        6178     6178              
==========================================
+ Hits         2899     2907       +8     
+ Misses       2980     2976       -4     
+ Partials      299      295       -4
Impacted Files Coverage Δ
pkg/skaffold/build/local/docker.go 59.52% <100%> (+14.28%) ⬆️
pkg/skaffold/build/local/local.go 33.33% <0%> (+3.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36fe897...a291569. Read the comment docs.

@dgageot dgageot merged commit 830346e into GoogleContainerTools:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants