Try to use the local docker to get the image config#1735
Merged
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom Mar 6, 2019
Merged
Try to use the local docker to get the image config#1735priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Otherwise, we might check an image that was only built locally and never pushed Fixes GoogleContainerTools#1734 Signed-off-by: David Gageot <david@gageot.net>
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
priyawadhwa
approved these changes
Mar 6, 2019
Contributor
priyawadhwa
left a comment
priyawadhwa
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, we might check an image that was only
built locally and never pushed
Fixes #1734
Signed-off-by: David Gageot david@gageot.net