Simplify integration tests#1750
Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom Mar 7, 2019
Merged
Conversation
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1750 +/- ##
==========================================
- Coverage 47.35% 47.08% -0.27%
==========================================
Files 126 127 +1
Lines 6179 6214 +35
==========================================
Hits 2926 2926
- Misses 2955 2990 +35
Partials 298 298
Continue to review full report at Codecov.
|
dgageot
force-pushed
the
simplify-integration
branch
from
e8c5861 to
9b043cf
Compare
Closed
+ Move `Gcloud` command to the Makefile + Remove TestMain. It makes it complicated to run a single test + Replace build tags with a check on `-short` so that tests are always compiled and linted + Fix lint errors on rpc_test.go + Some test projects should not be in ./integration/examples because they shouldn’t be in ./examples + Fix flakiness on TestDev Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
simplify-integration
branch
from
9b043cf to
9fe08b7
Compare
balopat
approved these changes
Mar 7, 2019
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
LGTM, one nit, and one question: when you say you fixed TestDev - was the root cause of the flake around job redeployment issues? I'm guessing based on your solution that is change job -> deployment and instead of 10 minutes sleep it keeps looping forever.
| dep, err := client.AppsV1().Deployments(ns.Name).Get(deployName, meta_v1.GetOptions{}) | ||
| if err != nil { | ||
| t.Fatalf("Could not find job: %s %s", ns.Name, jobName) | ||
| t.Fatalf("Could not find dep: %s %s", ns.Name, deployName) |
Contributor
There was a problem hiding this comment.
Suggested change
| t.Fatalf("Could not find dep: %s %s", ns.Name, deployName) | |
| t.Fatalf("Could not find deployment: %s %s", ns.Name, deployName) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gcloudcommand to the Makefile-shortso that tests are always compiled and lintedSigned-off-by: David Gageot david@gageot.net