Add back tracking of forwarded ports to avoid race condition#1780
Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom Mar 12, 2019
Merged
Add back tracking of forwarded ports to avoid race condition#1780balopat merged 1 commit intoGoogleContainerTools:masterfrom
balopat merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1780 +/- ##
==========================================
- Coverage 47.06% 46.12% -0.95%
==========================================
Files 130 133 +3
Lines 6261 6418 +157
==========================================
+ Hits 2947 2960 +13
- Misses 3012 3154 +142
- Partials 302 304 +2
Continue to review full report at Codecov.
|
balopat
approved these changes
Mar 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code adds tracking of which ports we've forwarded in the port forwarder. The motivation for this is to avoid a race condition where skaffold searches for open ports for two services in a very short period of time: kubectl doesn't have enough time to forward either of the ports, so skaffold thinks the provided port is available for both services, and the first one wins while the second one is not forwarded correctly.
This also adds the pod name and the namespace to the key we're using the track forwardedPods, which fixes a potential latent issue with two containers that share the same name.
cc @briandealwis