Faster integration tests#1789
Conversation
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1789 +/- ##
=======================================
Coverage 46.09% 46.09%
=======================================
Files 142 142
Lines 6576 6576
=======================================
Hits 3031 3031
Misses 3242 3242
Partials 303 303Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1789 +/- ##
=======================================
Coverage 46.09% 46.09%
=======================================
Files 142 142
Lines 6576 6576
=======================================
Hits 3031 3031
Misses 3242 3242
Partials 303 303Continue to review full report at Codecov.
|
dgageot
force-pushed
the
faster-integration-tests
branch
from
1f7a2a5 to
c005190
Compare
nkubala
left a comment
nkubala
left a comment
There was a problem hiding this comment.
😍 850 lines, down from 10000!
Makefile
Outdated
| -e DOCKER_CONFIG=/root/.docker \ | ||
| -e GOOGLE_APPLICATION_CREDENTIALS=$(GOOGLE_APPLICATION_CREDENTIALS) \ | ||
| gcr.io/$(GCP_PROJECT)/skaffold-integration | ||
| docker push gcr.io/$(GCP_PROJECT)/skaffold-integration |
There was a problem hiding this comment.
why do we need this? GCB pushes the images automatically
There was a problem hiding this comment.
I tried to pull this image and it didn't exist. So I'm not sure.
There was a problem hiding this comment.
Hmm...yeah you're right - deploy/cloudbuild.yaml only pushes up to the builder target in that dockerfile... why do we need to push this?
There was a problem hiding this comment.
When you say this, do you mean the builder image or the skaffold-integration image?
In case it's the latter, we need to push it to make sure it can be used by --cache-from two lines up in the script
There was a problem hiding this comment.
by this I meant integration.
integration is always different for every different version of skaffold as it is only builder + skaffold binary + a specific CMD? can't we just use --cache-from from the builder image?
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
LGTM - except the docker push - I'm not sure if it's necessary
|
@balopat Is there a GCB job that pushes this image? |
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
faster-integration-tests
branch
from
908b411 to
0efee13
Compare
6 participants
--cache-fromto build the integration tests Docker image.make testandmake coveragein a single step