Support ctrl-c during tagging and cache checking#1796
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Mar 14, 2019
Merged
Support ctrl-c during tagging and cache checking#1796dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Without this code, `skaffold build` can only be interrupted during the actual image building. Signed-off-by: David Gageot <david@gageot.net>
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1796 +/- ##
==========================================
- Coverage 46.08% 46.07% -0.01%
==========================================
Files 142 142
Lines 6577 6587 +10
==========================================
+ Hits 3031 3035 +4
- Misses 3243 3248 +5
- Partials 303 304 +1
Continue to review full report at Codecov.
|
balopat
approved these changes
Mar 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this code,
skaffold buildcan only beinterrupted during the actual image building.
Signed-off-by: David Gageot david@gageot.net