Skip to content

Initialize Artifact.Workspace to "." by default in plugin case too#1804

Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom
chanseokoh:fix-workspace-init
Mar 15, 2019
Merged

Initialize Artifact.Workspace to "." by default in plugin case too#1804
balopat merged 1 commit intoGoogleContainerTools:masterfrom
chanseokoh:fix-workspace-init

Conversation

@chanseokoh
Copy link
Copy Markdown
Member

Fixes #1803.

@chanseokoh chanseokoh changed the title Initialize workspace to "." by default Initialize Artifact.Workspace to "." by default in plugin case too Mar 15, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 15, 2019

Codecov Report

Merging #1804 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1804      +/-   ##
==========================================
+ Coverage   45.53%   45.54%   +<.01%     
==========================================
  Files         142      142              
  Lines        6626     6627       +1     
==========================================
+ Hits         3017     3018       +1     
  Misses       3307     3307              
  Partials      302      302
Impacted Files Coverage Δ
pkg/skaffold/schema/defaults/defaults.go 38.06% <100%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd40af1...8369f7b. Read the comment docs.

@balopat balopat merged commit 8a919d6 into GoogleContainerTools:master Mar 15, 2019
@chanseokoh chanseokoh deleted the fix-workspace-init branch March 15, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants