Faster git tagger#1817
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Mar 19, 2019
Merged
Conversation
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1817 +/- ##
=========================================
- Coverage 45.42% 45.4% -0.03%
=========================================
Files 143 143
Lines 6683 6680 -3
=========================================
- Hits 3036 3033 -3
Misses 3341 3341
Partials 306 306
Continue to review full report at Codecov.
|
dgageot
force-pushed
the
faster-git-tagger
branch
4 times, most recently
from
2066646 to
2c8176d
Compare
This code produces the same output in most cases. It also 20% faster. Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
faster-git-tagger
branch
from
2c8176d to
932f4f7
Compare
nkubala
approved these changes
Mar 19, 2019
Contributor
Author
|
The usual kaniko integration test is failing |
Contributor
|
"the usual" 🤕 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code produces the same output in most cases.
It also 20% faster.
Signed-off-by: David Gageot david@gageot.net