Skip to content

Support 1.11+ as a kubectl version#1843

Merged
dgageot merged 2 commits intoGoogleContainerTools:masterfrom
dgageot:fix-1842
Mar 20, 2019
Merged

Support 1.11+ as a kubectl version#1843
dgageot merged 2 commits intoGoogleContainerTools:masterfrom
dgageot:fix-1842

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Mar 20, 2019

Fixes #1842

dgageot added 2 commits March 20, 2019 11:36
Signed-off-by: David Gageot <david@gageot.net>
Fix GoogleContainerTools#1842

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 20, 2019

Codecov Report

Merging #1843 into master will increase coverage by 0.38%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1843      +/-   ##
=========================================
+ Coverage   47.91%   48.3%   +0.38%     
=========================================
  Files         144     144              
  Lines        6499    6501       +2     
=========================================
+ Hits         3114    3140      +26     
+ Misses       3101    3077      -24     
  Partials      284     284
Impacted Files Coverage Δ
pkg/skaffold/deploy/kubectl/version.go 86.66% <100%> (+86.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e4c4a9...79fdb79. Read the comment docs.

Copy link
Copy Markdown
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgageot dgageot merged commit 25e7208 into GoogleContainerTools:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants