Add portName to the PortEvent payload of the event api#1855
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Mar 22, 2019
etanshaul:master
Merged
Add portName to the PortEvent payload of the event api#1855dgageot merged 1 commit intoGoogleContainerTools:masterfrom etanshaul:master
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
etanshaul:master
Conversation
Contributor
Author
|
Hmm for some reason I'm not getting Investigating.. |
Contributor
Author
|
oops my fault. forgot to regenerate the client code from the proto on the other end :) |
Contributor
Author
|
ready for review. sample output from event api PortEvent: |
dgageot
approved these changes
Mar 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1798
Adds in the
portNamemainly so that clients can distinguish "normal" application port forwards from debug ports.