Skip to content

Add portName to the PortEvent payload of the event api#1855

Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
etanshaul:master
Mar 22, 2019
Merged

Add portName to the PortEvent payload of the event api#1855
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
etanshaul:master

Conversation

@etanshaul
Copy link
Copy Markdown
Contributor

fixes #1798

Adds in the portName mainly so that clients can distinguish "normal" application port forwards from debug ports.

@etanshaul
Copy link
Copy Markdown
Contributor Author

Hmm for some reason I'm not getting portName back even after these changes:

event {
  portEvent {
    localPort: 5005
    remotePort: 5005
    podName: "skaffold-spring-boot-5c4d6b7c94-s6ft8"
    containerName: "skaffold-spring-boot"
    namespace: "default"
  }
}

Investigating..

@etanshaul
Copy link
Copy Markdown
Contributor Author

oops my fault. forgot to regenerate the client code from the proto on the other end :)

@etanshaul
Copy link
Copy Markdown
Contributor Author

ready for review. sample output from event api PortEvent:

event {
  portEvent {
    localPort: 5005
    remotePort: 5005
    podName: "skaffold-spring-boot-5c4d6b7c94-k7qq9"
    containerName: "skaffold-spring-boot"
    namespace: "default"
    portName: "debug"
  }
}

@dgageot dgageot merged commit d07e88b into GoogleContainerTools:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add portName to event api portEvent

3 participants