Add missing env variables in CLI reference doc#1863
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Mar 23, 2019
Merged
Add missing env variables in CLI reference doc#1863dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1863 +/- ##
==========================================
+ Coverage 49.4% 49.63% +0.22%
==========================================
Files 166 166
Lines 7327 7328 +1
==========================================
+ Hits 3620 3637 +17
+ Misses 3357 3340 -17
- Partials 350 351 +1
Continue to review full report at Codecov.
|
balopat
approved these changes
Mar 22, 2019
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
Thanks for fixing this plus adding tests!!!!
(it was my bad that this got removed)
balopat
added
the
docs-modifications
|
Please visit http://35.236.65.79:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
balopat
reviewed
Mar 22, 2019
cmd/skaffold/man/man.go
Outdated
|
|
||
| command.LocalFlags().VisitAll(func(flag *pflag.Flag) { | ||
| fmt.Printf("* `%s` (same as --%s)\n", cmd.FlagToEnvVarName(flag), flag.Name) | ||
| fmt.Fprintf(out, "* `%s` (same as --%s)\n", cmd.FlagToEnvVarName(flag), flag.Name) |
Contributor
There was a problem hiding this comment.
Suggested change
| fmt.Fprintf(out, "* `%s` (same as --%s)\n", cmd.FlagToEnvVarName(flag), flag.Name) | |
| fmt.Fprintf(out, "* `%s` (same as `--%s`)\n", cmd.FlagToEnvVarName(flag), flag.Name) |
+ Add a unit test + Simplify the code Fixes GoogleContainerTools#1862 Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
test-skaffold-man
branch
from
4ac777e to
7d32677
Compare
briandealwis
added a commit
to briandealwis/skaffold
that referenced
this pull request
Mar 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1862
Signed-off-by: David Gageot david@gageot.net