Verify patches and fail with a proper error message#1864
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Mar 22, 2019
Merged
Verify patches and fail with a proper error message#1864dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Fixes GoogleContainerTools#1851 Signed-off-by: David Gageot <david@gageot.net>
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1864 +/- ##
==========================================
+ Coverage 49.21% 49.23% +0.02%
==========================================
Files 166 166
Lines 7293 7301 +8
==========================================
+ Hits 3589 3595 +6
- Misses 3355 3356 +1
- Partials 349 350 +1
Continue to review full report at Codecov.
|
balopat
approved these changes
Mar 22, 2019
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
Thank you for the quick fix, David!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1851
Signed-off-by: David Gageot david@gageot.net