Improve helm examples#1891
Merged
nkubala merged 3 commits intoGoogleContainerTools:masterfrom Apr 2, 2019
Merged
Conversation
The helm example was not very useful, because it neither built a container, nor served anything. Now, the helm example serves some static assets via a wildcard ingress. Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
corneliusweig
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1891 +/- ##
=======================================
Coverage 51.45% 51.45%
=======================================
Files 171 171
Lines 7690 7690
=======================================
Hits 3957 3957
Misses 3357 3357
Partials 376 376Continue to review full report at Codecov.
|
Serve static assets from a config map Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
tejal29
approved these changes
Apr 2, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The helm example was not very useful, because it neither built a container, nor served anything. Now, the helm example serves some static assets via a wildcard ingress.