Undo fmt.Fprint -> color.White.Fprint#1903
Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom Apr 2, 2019
Merged
Undo fmt.Fprint -> color.White.Fprint#1903balopat merged 1 commit intoGoogleContainerTools:masterfrom
balopat merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
tjk
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
casret
approved these changes
Apr 1, 2019
nkubala
approved these changes
Apr 1, 2019
Contributor
nkubala
left a comment
nkubala
left a comment
There was a problem hiding this comment.
tried it out with the experimental gui with light and dark backgrounds, seems to be fine. in general I think using white is probably not a great idea 😆
Codecov Report
@@ Coverage Diff @@
## master #1903 +/- ##
=======================================
Coverage 49.46% 49.46%
=======================================
Files 174 174
Lines 8036 8036
=======================================
Hits 3975 3975
Misses 3683 3683
Partials 378 378
Continue to review full report at Codecov.
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this would fix #1664 but not sure what it breaks about experimental GUI (dcfb2e3)?