Skip to content

Add some documentation for container structure tests#1959

Merged
priyawadhwa merged 3 commits intoGoogleContainerTools:masterfrom
corneliusweig:testers-docs
Apr 17, 2019
Merged

Add some documentation for container structure tests#1959
priyawadhwa merged 3 commits intoGoogleContainerTools:masterfrom
corneliusweig:testers-docs

Conversation

@corneliusweig
Copy link
Copy Markdown
Contributor

@corneliusweig corneliusweig commented Apr 14, 2019

Close #1917

@corneliusweig
Add some documentation for container structure tests
219f7fe 
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
@corneliusweig
Copy link
Copy Markdown
Contributor Author

corneliusweig commented Apr 14, 2019

@nkubala you are predestined to look at this 😉

@corneliusweig
Ignore structureTest sample when validating samples
7fc270f 
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 14, 2019 •
edited
Loading

Codecov Report

Merging #1959 into master will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1959      +/-   ##
==========================================
+ Coverage   52.58%   52.94%   +0.35%     
==========================================
  Files         180      183       +3     
  Lines        7898     7920      +22     
==========================================
+ Hits         4153     4193      +40     
+ Misses       3356     3327      -29     
- Partials      389      400      +11
Impacted Files Coverage Δ
pkg/skaffold/jib/jib.go 74.54% <0%> (-9.33%) ⬇️
cmd/skaffold/app/cmd/fix.go 65.62% <0%> (-4.38%) ⬇️
pkg/skaffold/util/util.go 64.92% <0%> (-3.05%) ⬇️
pkg/skaffold/schema/validation/validation.go 100% <0%> (ø) ⬆️
pkg/skaffold/schema/v1beta8/upgrade.go 66.66% <0%> (ø)
pkg/skaffold/util/config.go 68.42% <0%> (ø)
pkg/skaffold/schema/v1beta8/config.go 100% <0%> (ø)
cmd/skaffold/app/cmd/cmd.go 74.19% <0%> (+0.28%) ⬆️
cmd/skaffold/app/cmd/dev.go 20.75% <0%> (+0.38%) ⬆️
cmd/skaffold/app/cmd/run.go 36% <0%> (+1.38%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30da253...c436b33. Read the comment docs.

@priyawadhwa priyawadhwa added docs-modifications runs the docs preview service on the given PR kokoro:run runs the kokoro jobs on a PR labels Apr 17, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 17, 2019
@container-tools-bot
Copy link
Copy Markdown

container-tools-bot commented Apr 17, 2019

Error creating deployment, please see controller logs for details.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Apr 17, 2019
@container-tools-bot
Copy link
Copy Markdown

container-tools-bot commented Apr 17, 2019

Please visit http://35.236.52.55:1313 to view changes to the docs.

@container-tools-bot
Copy link
Copy Markdown

container-tools-bot commented Apr 17, 2019

Error creating deployment, please see controller logs for details.

priyawadhwa
priyawadhwa reviewed Apr 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, just left a couple suggestions.

Also not sure why the bot commented three times, but the link seems to be working 🤷‍♀️

@corneliusweig
Enhancements from review by @.priyawadhwa
c436b33 
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
@corneliusweig
Copy link
Copy Markdown
Contributor Author

corneliusweig commented Apr 17, 2019

@priyawadhwa Thanks for your enhancements! PTAL

@priyawadhwa priyawadhwa added the docs-modifications runs the docs preview service on the given PR label Apr 17, 2019
@container-tools-bot
Copy link
Copy Markdown

container-tools-bot commented Apr 17, 2019

Please visit http://35.236.122.247:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Apr 17, 2019
@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Apr 17, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 17, 2019
priyawadhwa
priyawadhwa approved these changes Apr 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for adding this!

@priyawadhwa priyawadhwa merged commit 6ed397d into GoogleContainerTools:master Apr 17, 2019
@corneliusweig corneliusweig deleted the testers-docs branch April 17, 2019 19:49
nkubala
nkubala reviewed Apr 18, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha this one slipped by me....thanks @corneliusweig :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@balopat balopat Awaiting requested review from balopat

@dgageot dgageot Awaiting requested review from dgageot

@r2d4 r2d4 Awaiting requested review from r2d4

2 more reviewers

@nkubala nkubala nkubala left review comments

@priyawadhwa priyawadhwa priyawadhwa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve documentation on testing phase

7 participants

@corneliusweig @codecov-io @container-tools-bot @nkubala @priyawadhwa @googlebot @kokoro-team