Use RunOrFailOutput instead of RunOrFail to see the error logs in test#1976
Merged
Use RunOrFailOutput instead of RunOrFail to see the error logs in test#1976
RunOrFailOutput instead of RunOrFail to see the error logs in test#1976Conversation
… test. Use `RunOrFailOutput` instead of `RunOrFail` to see the error logs in test.
tejal29
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
tejal29
changed the title
RunOrFailOutput instead of RunOrFail to see the error logs in…RunOrFailOutput instead of RunOrFail to see the error logs in test
Codecov Report
@@ Coverage Diff @@
## master #1976 +/- ##
=======================================
Coverage 52.94% 52.94%
=======================================
Files 183 183
Lines 7920 7920
=======================================
Hits 4193 4193
Misses 3327 3327
Partials 400 400Continue to review full report at Codecov.
|
We use the test.description as test name
```
t.Run(test.description, func(t *testing.T) {
```
Adding "-", makes it hard to run the test individually on command line and needs escaping.
```
REMOTE_INTEGRATION=true go test -v github.com/GoogleContainerTools/skaffold/integration -run TestRun/Google_Cloud_Build_-_sub_folder
=== RUN TestRun
--- PASS: TestRun (0.00s)
testing: warning: no tests to run
PASS
ok github.com/GoogleContainerTools/skaffold/integration (cached) [no tests to run]
```
These tests were not correctly passing the test.args set in the test case.
dgageot
approved these changes
Apr 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… test.
Use
RunOrFailOutputinstead ofRunOrFailto see the error logs in test.