Add hidden flag --force-colors to always print color codes#2033
Merged
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom Apr 26, 2019
Merged
Add hidden flag --force-colors to always print color codes#2033priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
--force-colors to always print color codes#2033priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
corneliusweig
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
corneliusweig
changed the title
--force-colors to always print color codes
Codecov Report
@@ Coverage Diff @@
## master #2033 +/- ##
==========================================
- Coverage 55.96% 55.94% -0.03%
==========================================
Files 173 173
Lines 7556 7563 +7
==========================================
+ Hits 4229 4231 +2
- Misses 2924 2928 +4
- Partials 403 404 +1
Continue to review full report at Codecov.
|
priyawadhwa
approved these changes
Apr 26, 2019
Contributor
priyawadhwa
left a comment
priyawadhwa
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2021