Remove podname from port forward key#2047
Merged
nkubala merged 1 commit intoGoogleContainerTools:masterfrom May 1, 2019
Merged
Remove podname from port forward key#2047nkubala merged 1 commit intoGoogleContainerTools:masterfrom
nkubala merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
This way, when pods are regenerated, they will be mapped to the same port. This should fix some of the issues users have been facing in GoogleContainerTools#1815 and GoogleContainerTools#1594.
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2047 +/- ##
=======================================
Coverage 55.93% 55.93%
=======================================
Files 178 178
Lines 7689 7689
=======================================
Hits 4301 4301
Misses 2973 2973
Partials 415 415
Continue to review full report at Codecov.
|
nkubala
approved these changes
May 1, 2019
Contributor
|
is there a way to add a test for it? The test will help not breaking it in future. |
This was referenced May 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, when pods are regenerated, they will be mapped to the same
port.
This should fix some of the issues users have been facing in #1815 and #1594.