Add dockerfile to custom dependencies#2049
Merged
priyawadhwa merged 2 commits intoGoogleContainerTools:masterfrom May 8, 2019
Merged
Add dockerfile to custom dependencies#2049priyawadhwa merged 2 commits intoGoogleContainerTools:masterfrom
priyawadhwa merged 2 commits intoGoogleContainerTools:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2049 +/- ##
==========================================
+ Coverage 55.93% 56.17% +0.24%
==========================================
Files 178 180 +2
Lines 7689 7768 +79
==========================================
+ Hits 4301 4364 +63
- Misses 2973 2987 +14
- Partials 415 417 +2
Continue to review full report at Codecov.
|
tejal29
suggested changes
May 3, 2019
tejal29
approved these changes
May 8, 2019
Contributor
tejal29
left a comment
There was a problem hiding this comment.
LGTM,
I am not aware if current config version is frozen. Please verify before you merge!.
Contributor
Author
|
Yup, we've frozen v1beta9 from the last release and this is making changes to v1beta10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows users to say something like: