Skip to content

🐛 fix kubectl apply error handling#2076

Merged
nkubala merged 1 commit intoGoogleContainerTools:masterfrom
pyaillet:issue_1738
May 7, 2019
Merged

🐛 fix kubectl apply error handling#2076
nkubala merged 1 commit intoGoogleContainerTools:masterfrom
pyaillet:issue_1738

Conversation

@pyaillet
Copy link
Copy Markdown
Contributor

@pyaillet pyaillet commented May 6, 2019

Hi !

Thanks for skaffold it's a really nice project !

I gave a try at fixing #1738 😄

Thanks to @charlyx for his help 🤗

@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label May 6, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 6, 2019
@nkubala nkubala merged commit d303b00 into GoogleContainerTools:master May 7, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.11%. Comparing base (25f1b66) to head (5643ce0).

Files with missing lines Patch % Lines
pkg/skaffold/deploy/kustomize.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2076      +/-   ##
==========================================
- Coverage   56.12%   56.11%   -0.01%     
==========================================
  Files         180      180              
  Lines        7753     7755       +2     
==========================================
+ Hits         4351     4352       +1     
- Misses       2986     2987       +1     
  Partials      416      416              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants