🐛 fix kubectl apply error handling#2076
Merged
nkubala merged 1 commit intoGoogleContainerTools:masterfrom May 7, 2019
pyaillet:issue_1738
Merged
🐛 fix kubectl apply error handling#2076nkubala merged 1 commit intoGoogleContainerTools:masterfrom pyaillet:issue_1738
nkubala merged 1 commit intoGoogleContainerTools:masterfrom
pyaillet:issue_1738
Conversation
tejal29
approved these changes
May 6, 2019
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2076 +/- ##
==========================================
- Coverage 56.12% 56.11% -0.01%
==========================================
Files 180 180
Lines 7753 7755 +2
==========================================
+ Hits 4351 4352 +1
- Misses 2986 2987 +1
Partials 416 416 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi !
Thanks for
skaffoldit's a really nice project !I gave a try at fixing #1738 😄
Thanks to @charlyx for his help 🤗