Skip to content

Mention kind in docs for local development#2090

Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom
corneliusweig:docs/local-with-kind
May 8, 2019
Merged

Mention kind in docs for local development#2090
balopat merged 1 commit intoGoogleContainerTools:masterfrom
corneliusweig:docs/local-with-kind

Conversation

@corneliusweig
Copy link
Copy Markdown
Contributor

See #1980

@corneliusweig
Copy link
Copy Markdown
Contributor Author

I'm asking myself, if it is acceptable to link to answers on github issues from the skaffold.dev docs.

I think this could help people getting more detailed information while at the same time keeping the docs somewhat manageable. On the other hand, the "doc experience" with github issues is not very comfortable. WDYT?

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2090 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2090   +/-   ##
=======================================
  Coverage   56.12%   56.12%           
=======================================
  Files         180      180           
  Lines        7756     7756           
=======================================
  Hits         4353     4353           
  Misses       2987     2987           
  Partials      416      416

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceda301...fca0b0e. Read the comment docs.

@balopat
Copy link
Copy Markdown
Contributor

balopat commented May 8, 2019

I'm asking myself, if it is acceptable to link to answers on github issues from the skaffold.dev docs.

I think this could help people getting more detailed information while at the same time keeping the docs somewhat manageable. On the other hand, the "doc experience" with github issues is not very comfortable. WDYT?

I think we should in general copy and sanitize reference type of information from Github issues as they are "mutable" things can change, deleted, moved and originally meant for discussion not for documentation. For historical reference we can definitely link to them - but not more than that.

@balopat balopat merged commit a117236 into GoogleContainerTools:master May 8, 2019
@corneliusweig corneliusweig deleted the docs/local-with-kind branch May 8, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants