Skip to content

Freeze v1beta10 config#2109

Merged
nkubala merged 1 commit intoGoogleContainerTools:masterfrom
corneliusweig:freeze-v1beta10
May 20, 2019
Merged

Freeze v1beta10 config#2109
nkubala merged 1 commit intoGoogleContainerTools:masterfrom
corneliusweig:freeze-v1beta10

Conversation

@corneliusweig
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label May 10, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 10, 2019
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2109 into master will increase coverage by 0.05%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2109      +/-   ##
==========================================
+ Coverage   56.29%   56.35%   +0.05%     
==========================================
  Files         180      182       +2     
  Lines        7794     7822      +28     
==========================================
+ Hits         4388     4408      +20     
- Misses       2989     2993       +4     
- Partials      417      421       +4
Impacted Files Coverage Δ
pkg/skaffold/schema/versions.go 74.35% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta9/upgrade.go 84.9% <ø> (ø) ⬆️
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta10/config.go 100% <100%> (ø)
pkg/skaffold/schema/v1beta10/upgrade.go 66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2df4ce...625bc82. Read the comment docs.

@tejal29
Copy link
Copy Markdown
Contributor

tejal29 commented May 10, 2019

@corneliusweig do you have a config change PR ready to merge?
We don't usually bump it unless there is a config change in pipeline.
If there is an PR, please add this to the ticket

@corneliusweig
Copy link
Copy Markdown
Contributor Author

corneliusweig commented May 10, 2019

@tejal29 So there are #2088 and #1905.

I could as well cherry-pick this PR on top of #2088 and #1905 goes under the radar. WDYT?

Copy link
Copy Markdown
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's wait until we are closer with one of these with merging https://github.com/GoogleContainerTools/skaffold/pulls?q=is%3Apr+is%3Aopen+label%3A%22%21%21+config-change+%21%21%22

This is the most awkward process we have :/

@nkubala nkubala dismissed balopat’s stale review May 20, 2019 18:35

this is ready

@nkubala nkubala merged commit eb9916f into GoogleContainerTools:master May 20, 2019
@corneliusweig corneliusweig deleted the freeze-v1beta10 branch May 20, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants