Don't panic for nil pod watch object#2112
Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom May 14, 2019
tbarrella:build-panic
Merged
Don't panic for nil pod watch object#2112balopat merged 1 commit intoGoogleContainerTools:masterfrom tbarrella:build-panic
balopat merged 1 commit intoGoogleContainerTools:masterfrom
tbarrella:build-panic
Conversation
tbarrella
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2112 +/- ##
==========================================
- Coverage 56.29% 56.28% -0.02%
==========================================
Files 180 180
Lines 7794 7796 +2
==========================================
Hits 4388 4388
- Misses 2989 2991 +2
Partials 417 417
Continue to review full report at Codecov.
|
balopat
approved these changes
May 14, 2019
Contributor
|
Thank you for your contribution! |
Contributor
Author
|
(Thank you! I'm a big fan of Skaffold and everyone's work on it; wish I could contribute more) |
Contributor
|
@tbarrella if you're interested in contributing more, here's a list of good first issues, and possibly more complicated issues we'd love some help with here! |
Contributor
Author
|
Cool, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to fix #2103