✨ Add option --no-prune-children#2113
Merged
nkubala merged 1 commit intoGoogleContainerTools:masterfrom May 15, 2019
Merged
Conversation
charlyx
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2113 +/- ##
==========================================
- Coverage 56.29% 56.28% -0.02%
==========================================
Files 180 180
Lines 7794 7798 +4
==========================================
+ Hits 4388 4389 +1
- Misses 2989 2992 +3
Partials 417 417
Continue to review full report at Codecov.
|
balopat
approved these changes
May 14, 2019
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
Thank you, this LGTM, can you please rebase?
charlyx
force-pushed
the
issue-2050-prune-children-config
branch
from
c3f78da to
000b188
Compare
Contributor
Author
|
@balopat done 👌 |
priyawadhwa
added
kokoro:run
Contributor
|
@charlyx thanks for this one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
This PR adds
--no-prune-childrenflag.I hope it meets issue #2050 expectations.
I'm not sure the description of the flag I made is OK though...
I'll be happy with suggestions.