Fix bugs in custom builder#2130
Merged
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom May 15, 2019
Merged
Conversation
This PR fixes the following bugs in the custom builder: 1. The build command should be run in the artifact context (GoogleContainerTools#2125) 2. The build command should be split into executable+arguments so that flags can be passed in This PR also adds a unit test for each of these bugs.
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2130 +/- ##
==========================================
+ Coverage 56.28% 56.35% +0.06%
==========================================
Files 180 180
Lines 7796 7806 +10
==========================================
+ Hits 4388 4399 +11
+ Misses 2991 2988 -3
- Partials 417 419 +2
Continue to review full report at Codecov.
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following bugs in the custom builder:
flags can be passed in
This PR also adds a unit test for each of these bugs.