skaffold debug: log unsupported objects or versions#2138
Merged
dgageot merged 2 commits intoGoogleContainerTools:masterfrom May 17, 2019
Merged
skaffold debug: log unsupported objects or versions#2138dgageot merged 2 commits intoGoogleContainerTools:masterfrom
dgageot merged 2 commits intoGoogleContainerTools:masterfrom
Conversation
briandealwis
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
tejal29
reviewed
May 16, 2019
| } else { | ||
| description = fmt.Sprintf("%s.%s/%s", strings.ToLower(kind), group, name) | ||
| } | ||
| return |
Contributor
There was a problem hiding this comment.
we dont return anything here or am i missing some hidden go mojo that happens here?
Member
Author
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #2138 +/- ##
==========================================
+ Coverage 56.31% 56.34% +0.02%
==========================================
Files 180 180
Lines 7815 7836 +21
==========================================
+ Hits 4401 4415 +14
- Misses 2994 3001 +7
Partials 420 420
Continue to review full report at Codecov.
|
dgageot
approved these changes
May 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't support workload objects in
apps/v1beta1orapps/v1beta2, which have been deprecated since Kubernetes 1.9. Log these in a more visible manner:The warning should only be issued workload API objects (
appsandbatch) that aren't handled.