Check for env variables for root cmd persistent flags#2143
Merged
dgageot merged 2 commits intoGoogleContainerTools:masterfrom May 17, 2019
Merged
Check for env variables for root cmd persistent flags#2143dgageot merged 2 commits intoGoogleContainerTools:masterfrom
dgageot merged 2 commits intoGoogleContainerTools:masterfrom
Conversation
added 2 commits
May 16, 2019 15:34
We were checking for environment variables for subcommands of `skaffold`, but not the global flags that directly apply to the `skaffold` root cmd. This should allow us to also specify `SKAFFOLD_FORCE_COLORS` as an env variable, fixing GoogleContainerTools#2139. I wasn't sure how to unit test this without changing the environment variable locally, and I didn't want to risk messing up anyone's configuration. However, I tested locally and the env variable seems to be working now.
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2143 +/- ##
==========================================
- Coverage 56.31% 56.31% -0.01%
==========================================
Files 180 180
Lines 7815 7819 +4
==========================================
+ Hits 4401 4403 +2
- Misses 2994 2995 +1
- Partials 420 421 +1
Continue to review full report at Codecov.
|
dgageot
approved these changes
May 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were checking for environment variables for subcommands of
skaffold, but not the global flags that directly apply to theskaffoldroot cmd.
This should allow us to also specify
SKAFFOLD_FORCE_COLORSas an envvariable, fixing #2139.
I wasn't sure how to unit test this without changing the environment
variable locally, and I didn't want to risk messing up anyone's
configuration. However, I tested locally and the env variable seems to
be working now.