Test helper to override value for tests#2147
Merged
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom May 20, 2019
Merged
Test helper to override value for tests#2147tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
Conversation
Signed-off-by: David Gageot <david@gageot.net>
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2147 +/- ##
=======================================
Coverage 56.73% 56.73%
=======================================
Files 183 183
Lines 7902 7902
=======================================
Hits 4483 4483
Misses 3003 3003
Partials 416 416Continue to review full report at Codecov.
|
tejal29
approved these changes
May 17, 2019
nkubala
reviewed
May 17, 2019
Contributor
nkubala
left a comment
nkubala
left a comment
There was a problem hiding this comment.
I think this wouldn't work if we ever switched to run these tests in parallel, but I guess what we have right now probably wouldn't work anyway.
+1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a helper function to testutil to override variables for tests and restore them at the end.
wdyt about it?
The only issue is that when the variable type changes, there's no compilation error. It's detected when the test runs. If think it's ok.
If you like it, I can modify the whole codebase.