Add smoke test for skaffold diagnose#2157
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom May 21, 2019
Merged
Add smoke test for skaffold diagnose#2157dgageot merged 1 commit intoGoogleContainerTools:masterfrom
skaffold diagnose#2157dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Try to cover all artifact types Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
corneliusweig
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
tejal29
approved these changes
May 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #2157 +/- ##
=========================================
+ Coverage 56.74% 56.95% +0.2%
=========================================
Files 183 183
Lines 7860 7961 +101
=========================================
+ Hits 4460 4534 +74
- Misses 2988 3012 +24
- Partials 412 415 +3
Continue to review full report at Codecov.
|
Contributor
|
Nice!!! Thank you for this! |
dgageot
approved these changes
May 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
skaffold diagnosecommand has bad test coverage (both integration and unit tests). There are reasons why it may not make sense to have full unit test coverage there. However, basic test coverage should be there to check whether the subcommand runs at all.This PR adds basic smoke tests which check if
skaffold diagnoseruns successfully. It covers all artifact types that have an example.