Fix error in flag refactoring for skaffold run --tail#2172
Merged
dgageot merged 2 commits intoGoogleContainerTools:masterfrom May 27, 2019
Merged
Fix error in flag refactoring for skaffold run --tail#2172dgageot merged 2 commits intoGoogleContainerTools:masterfrom
skaffold run --tail#2172dgageot merged 2 commits intoGoogleContainerTools:masterfrom
Conversation
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
corneliusweig
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
corneliusweig
changed the title
skaffold run --tail
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #2172 +/- ##
=======================================
Coverage 57.41% 57.41%
=======================================
Files 187 187
Lines 7905 7905
=======================================
Hits 4539 4539
Misses 2954 2954
Partials 412 412
Continue to review full report at Codecov.
|
dgageot
approved these changes
May 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/skaffold/runner/run.go:27 clearly checks for
opts.Tail, but the log-tailing forskaffold runusedopts.TailDev.Fix #2167