Check man page with a unit test instead of a script#2180
Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom Jun 4, 2019
Merged
Check man page with a unit test instead of a script#2180balopat merged 1 commit intoGoogleContainerTools:masterfrom
balopat merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2180 +/- ##
=======================================
Coverage 58.55% 58.55%
=======================================
Files 188 188
Lines 7882 7882
=======================================
Hits 4615 4615
Misses 2877 2877
Partials 390 390Continue to review full report at Codecov.
|
Member
briandealwis
left a comment
briandealwis
left a comment
There was a problem hiding this comment.
Is the idea here that contributors are more likely to see this error before they submit rather than during the CI build? Or are you looking to move the testing steps from make test into the normal testing flow?
Contributor
Author
|
It should be the same for contributors. Yes, the idea is to move the testing steps from |
Contributor
Author
|
@balopat Could you TAL at this one. It's very minor |
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
check-man-unit-test
branch
from
22a26b0 to
c4d9702
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot david@gageot.net