Skip to content

Test tester#2181

Merged
dgageot merged 4 commits intoGoogleContainerTools:masterfrom
dgageot:test-tester
May 28, 2019
Merged

Test tester#2181
dgageot merged 4 commits intoGoogleContainerTools:masterfrom
dgageot:test-tester

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented May 27, 2019

No description provided.

dgageot added 4 commits May 27, 2019 13:17
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2181 into master will increase coverage by 0.49%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2181      +/-   ##
==========================================
+ Coverage   57.41%   57.91%   +0.49%     
==========================================
  Files         187      187              
  Lines        7905     7900       -5     
==========================================
+ Hits         4539     4575      +36     
+ Misses       2954     2912      -42     
- Partials      412      413       +1
Impacted Files Coverage Δ
pkg/skaffold/runner/runner.go 68.85% <100%> (+1.11%) ⬆️
pkg/skaffold/test/test.go 87.09% <100%> (+72.39%) ⬆️
pkg/skaffold/test/structure/types.go 100% <0%> (+100%) ⬆️
pkg/skaffold/test/structure/structure.go 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d458fa5...21c6d00. Read the comment docs.

Copy link
Copy Markdown
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,142 @@
/*
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ this file name

@dgageot dgageot merged commit df15e97 into GoogleContainerTools:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants