Skip to content

Multiple small improvements to unit tests#2189

Merged
tejal29 merged 4 commits intoGoogleContainerTools:masterfrom
dgageot:simplify-tests
May 28, 2019
Merged

Multiple small improvements to unit tests#2189
tejal29 merged 4 commits intoGoogleContainerTools:masterfrom
dgageot:simplify-tests

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented May 28, 2019

  • Simplify the testutil.SetEnv() helper
  • Use testutil.Override where possible
  • Use util.OSEnviron() everywhere

dgageot added 4 commits May 28, 2019 13:57
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2189 into master will not change coverage.
The diff coverage is 25%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2189   +/-   ##
=======================================
  Coverage   57.91%   57.91%           
=======================================
  Files         187      187           
  Lines        7900     7900           
=======================================
  Hits         4575     4575           
  Misses       2912     2912           
  Partials      413      413
Impacted Files Coverage Δ
pkg/skaffold/util/env_template.go 76.47% <ø> (ø) ⬆️
pkg/skaffold/build/local/docker.go 53.19% <0%> (ø) ⬆️
pkg/skaffold/build/local/jib_maven.go 26.66% <0%> (ø) ⬆️
pkg/skaffold/build/local/jib_gradle.go 0% <0%> (ø) ⬆️
pkg/skaffold/build/custom/custom.go 66.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df15e97...63f274f. Read the comment docs.

@tejal29 tejal29 merged commit c796ee6 into GoogleContainerTools:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants