Test helper to make tests less verbose#2193
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Jun 4, 2019
Merged
Test helper to make tests less verbose#2193dgageot merged 1 commit intoGoogleContainerTools:masterfrom
dgageot merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2193 +/- ##
=======================================
Coverage 58.14% 58.14%
=======================================
Files 188 188
Lines 7863 7863
=======================================
Hits 4572 4572
Misses 2919 2919
Partials 372 372Continue to review full report at Codecov.
|
balopat
approved these changes
May 30, 2019
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
I think it's pretty cool to fold our test utilities into a testing.T like structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do you think of such test helper?