Merged
Conversation
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
dgageot
requested review from
TadCordle,
balopat,
briandealwis,
chanseokoh,
loosebazooka,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2195 +/- ##
==========================================
+ Coverage 57.88% 58.47% +0.58%
==========================================
Files 187 187
Lines 7903 7874 -29
==========================================
+ Hits 4575 4604 +29
+ Misses 2915 2876 -39
+ Partials 413 394 -19
Continue to review full report at Codecov.
|
balopat
reviewed
May 30, 2019
| WriteCloser: &nopCloser{Writer: &b}, | ||
| } | ||
|
|
||
| n, err := Green.Fprint(coloredWriter, "It's not easy being") |
Contributor
There was a problem hiding this comment.
being what? or just existing in general? :)
Contributor
Author
There was a problem hiding this comment.
I think you have to ask @bobcatfish who wrote the original test!
balopat
approved these changes
May 30, 2019
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
LGTM, thank you for increasing our test coverage!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.