Skip to content

Freeze v1beta11 config#2207

Closed
michaelbeaumont wants to merge 1 commit intoGoogleContainerTools:masterfrom
michaelbeaumont:mb/config
Closed

Freeze v1beta11 config#2207
michaelbeaumont wants to merge 1 commit intoGoogleContainerTools:masterfrom
michaelbeaumont:mb/config

Conversation

@michaelbeaumont
Copy link
Copy Markdown
Contributor

#2188 would be ready to review/test/merge

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 1, 2019

Codecov Report

Merging #2207 into master will increase coverage by 0.04%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2207      +/-   ##
==========================================
+ Coverage   58.55%   58.59%   +0.04%     
==========================================
  Files         188      190       +2     
  Lines        7882     7910      +28     
==========================================
+ Hits         4615     4635      +20     
- Misses       2877     2881       +4     
- Partials      390      394       +4
Impacted Files Coverage Δ
pkg/skaffold/schema/v1beta10/upgrade.go 66.66% <ø> (ø) ⬆️
pkg/skaffold/schema/versions.go 74.35% <ø> (ø) ⬆️
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta11/config.go 100% <100%> (ø)
pkg/skaffold/schema/v1beta11/upgrade.go 66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b139240...f172649. Read the comment docs.

@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Jun 14, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jun 17, 2019
@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Jun 19, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jun 19, 2019
@balopat
Copy link
Copy Markdown
Contributor

balopat commented Jun 25, 2019

Closing in favor for #2329.

@balopat balopat closed this Jun 25, 2019
@michaelbeaumont michaelbeaumont deleted the mb/config branch June 25, 2019 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants