Merged
Conversation
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
nkubala
reviewed
Jun 3, 2019
| script: | ||
| - make | ||
| - os: windows | ||
| go: "1.11.x" |
Contributor
There was a problem hiding this comment.
does go 1.12 work on windows?
Contributor
Author
There was a problem hiding this comment.
yes. I wanted to start small :-)
dgageot
force-pushed
the
ci-windows
branch
3 times, most recently
from
0f80b31 to
6fd9c0a
Compare
Signed-off-by: David Gageot <david@gageot.net>
Contributor
Author
balopat
approved these changes
Jun 4, 2019
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
LGTM - as discussed, let's try this out - I'm in favor of simplifying our infrastructure
Contributor
|
+1, I think consolidating infrastructure > "redundancy" in case of an outage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot david@gageot.net