tests for local.NewBuilder#2240
Merged
dgageot merged 3 commits intoGoogleContainerTools:masterfrom Jun 8, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2240 +/- ##
==========================================
+ Coverage 60.03% 60.61% +0.58%
==========================================
Files 185 185
Lines 7794 7798 +4
==========================================
+ Hits 4679 4727 +48
+ Misses 2728 2683 -45
- Partials 387 388 +1
Continue to review full report at Codecov.
|
dgageot
approved these changes
Jun 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also improved a little bit the
Overridefunction to help when there is a mistake while using it in tests - originally it just threw a cryptic panic during teardown.