Upgrade golangci-lint to v1.17.1#2248
Merged
balopat merged 3 commits intoGoogleContainerTools:masterfrom Jun 13, 2019
Merged
Conversation
And fix new reported issues Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
corneliusweig
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
nkubala
approved these changes
Jun 10, 2019
nkubala
previously requested changes
Jun 10, 2019
Contributor
nkubala
left a comment
nkubala
left a comment
There was a problem hiding this comment.
ah, can you run ./hack/check-docs.sh
Contributor
Author
|
@nkubala Whoops sorry. Should have thought about that. I think the travis run has hit some data-race which has nothing to do with these changes. |
Contributor
|
yupp, this fixes it: #2251 ....
for _, phase := range test.phases {
if fakeWatcher.IsStopped() {
break
}
/// at this point fakeWatcher could stop and
/// Modify then tried to send a message to a closed channel
fakeWatcher.Modify(&v1.Pod{
Status: v1.PodStatus{
Phase: phase,
},
})
time.Sleep(time.Second)
}
.... |
Contributor
Author
|
I merged master to get a clean travis build. |
dgageot
approved these changes
Jun 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And fix new reported issues