fix static linking of linux binary#2252
Merged
balopat merged 5 commits intoGoogleContainerTools:masterfrom Jun 12, 2019
Merged
Conversation
balopat
requested review from
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
Contributor
Author
|
This should work. Tested the binaries manually on all debian/alpine, darwin and windows. |
nkubala
approved these changes
Jun 11, 2019
Contributor
nkubala
left a comment
nkubala
left a comment
There was a problem hiding this comment.
would be great to get some sort of acceptance tests for different linux distros. that can come later though
valery-vitko
added a commit
to Steinpilz/docker
that referenced
this pull request
Jun 27, 2019
Downgrade to a previous version until fix for executing on Alpine linux released (GoogleContainerTools/skaffold#2252) in a version after v0.32.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2243.