Handle simple glob patterns when upgrading the sync patterns#2287
Merged
dgageot merged 2 commits intoGoogleContainerTools:masterfrom Jun 19, 2019
Merged
Conversation
Also simple glob patterns are flattened at the destination. The translation to the new sync config was not handled correctly for cases such as: - public/*: /app/public - public/index.html: /app/public Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
c387824 to
74bede4
Compare
Contributor
|
@corneliusweig you have a linter error: https://travis-ci.org/GoogleContainerTools/skaffold/jobs/547387037#L555 |
dgageot
approved these changes
Jun 19, 2019
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
74bede4 to
b767165
Compare
Contributor
Author
|
Whoops o_O .. fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also simple glob patterns are flattened at the destination. The translation to the new sync config was not handled correctly for cases such as:
Now, for compatible source patterns, the
stripfield is correctly populated. For example:IN:
OUT (
skaffold fix):This requires also a simplification of the sync rule, if
stripis a suffix ofdest, which is now also applied to triple-star patterns.Fix #2280