Support buildArgs with useDockerCLI=false and Kaniko#2299
Merged
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom Jun 20, 2019
Merged
Support buildArgs with useDockerCLI=false and Kaniko#2299tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
useDockerCLI=false and Kaniko#2299tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
Conversation
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
+ Add better tests for docker.Build() + Remove some duplication Fix GoogleContainerTools#2234 Signed-off-by: David Gageot <david@gageot.net>
Fix GoogleContainerTools#2153 Signed-off-by: David Gageot <david@gageot.net>
dgageot
changed the title
useDockerCLI=falseuseDockerCLI=false and Kaniko
Codecov Report
|
tejal29
approved these changes
Jun 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2234
Signed-off-by: David Gageot david@gageot.net