Skip to content

Handle eu.gcr.io like gcr.io when replacing default image#2300

Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-2185
Jun 20, 2019
Merged

Handle eu.gcr.io like gcr.io when replacing default image#2300
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:fix-2185

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Jun 20, 2019

Fix #2185

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 20, 2019

Codecov Report

Merging #2300 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/util/image.go 100% <100%> (ø) ⬆️
pkg/skaffold/jib/jib.go 78.49% <0%> (+1.07%) ⬆️

@balopat balopat merged commit f07a695 into GoogleContainerTools:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image repo handling strategies don't work for EU repos

4 participants