Refactor the SkaffoldRunner#2307
Merged
dgageot merged 1 commit intoGoogleContainerTools:masterfrom Jun 21, 2019
Merged
Conversation
This doesn’t add any feature. I just tried to clean things up. One small detail though is that now, the logger is started just after the build and just before the deploy. It used to be called, just after the deploy with the risk on losing logs. Signed-off-by: David Gageot <david@gageot.net>
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
|
briandealwis
approved these changes
Jun 21, 2019
Member
briandealwis
left a comment
briandealwis
left a comment
There was a problem hiding this comment.
Makes sense to me! Clears up some of the confusion I encountered elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn’t add any feature. I just tried to clean things up.
One small detail though is that now, the logger is started just after the build and just before the deploy. It used to be called just after the deploy, with the risk on losing logs.
Signed-off-by: David Gageot david@gageot.net