Add scripts to test and generate files from proto#2316
Merged
balopat merged 10 commits intoGoogleContainerTools:masterfrom Jun 22, 2019
Merged
Add scripts to test and generate files from proto#2316balopat merged 10 commits intoGoogleContainerTools:masterfrom
balopat merged 10 commits intoGoogleContainerTools:masterfrom
Conversation
added 8 commits
June 19, 2019 15:37
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
Codecov Report
|
Contributor
|
Fixes #2294. |
balopat
suggested changes
Jun 21, 2019
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
this is awesome, I'm excited to have this :)
Thank you!
Just two nits otherwise LGTM!
balopat
approved these changes
Jun 21, 2019
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
LGTM, looks good after fixing the boilerplate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Dockerfile which generates files from skaffold.proto and compares them to the existing files.
The dockerfile is used in
generate-proto.sh, where generated files are created in a container and then copied into a local filesystem. It's also used intest-generated-proto.sh, which compares the local files to the generated ones.