Improve the logs#2323
Merged
tejal29 merged 8 commits intoGoogleContainerTools:masterfrom Jun 28, 2019
Merged
Conversation
Contributor
dgageot
commented
Jun 23, 2019
dgageot
commented
- Don’t leak go routines
- Never reprint the log for a given container
- Simplify code
- Handle init containers first
- Notify that container logs ended
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
Contributor
Author
|
@balopat I simplified my PR because it was buggy. I decided to stop printing the container's final state because it's too unreliable. Printing when container logs end is, if think, good enough. |
Codecov Report
|
dgageot
force-pushed
the
final-logs-2
branch
6 times, most recently
from
81e55cc to
dc122a3
Compare
Make sure streamRequest() exits. Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
But once deploy is done, print the logs up the just before deploy was started. Signed-off-by: David Gageot <david@gageot.net>
tejal29
approved these changes
Jun 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.