Add support for user defined port forwarding#2336
Merged
priyawadhwa merged 13 commits intoGoogleContainerTools:masterfrom Jun 28, 2019
Merged
Add support for user defined port forwarding#2336priyawadhwa merged 13 commits intoGoogleContainerTools:masterfrom
priyawadhwa merged 13 commits intoGoogleContainerTools:masterfrom
Conversation
added 10 commits
June 24, 2019 11:25
|
Please visit http://35.236.53.50:1313 to view changes to the docs. |
Codecov Report
|
added 2 commits
June 26, 2019 10:31
|
Please visit http://35.236.70.48:1313 to view changes to the docs. |
This was referenced Jun 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for user defined port forwarding and updates docs around it.
Users can now add something like the following to their skaffold config:
This PR adds validation for
resourceTypeand sets defaults onnamespaceandlocalPortif not specified in the config. Also adds unit tests to test for each of these cases.