Skip to content

Fix support for URL manifests#2348

Merged
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:kubectl-http
Jul 1, 2019
Merged

Fix support for URL manifests#2348
balopat merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:kubectl-http

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Jun 26, 2019

Fix #2322

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 26, 2019

Codecov Report

Merging #2348 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/kubectl.go 71.95% <100%> (+2.61%) ⬆️

@dgageot dgageot force-pushed the kubectl-http branch 7 times, most recently from b4174fa to c790689 Compare July 1, 2019 13:59
@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Jul 1, 2019
Fix GoogleContainerTools#2322

Signed-off-by: David Gageot <david@gageot.net>
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jul 1, 2019
Copy link
Copy Markdown
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1 for the test

@balopat balopat merged commit 227fe48 into GoogleContainerTools:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove

5 participants